Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1918055: Update agg error for unsupported aggregation functions #3133

Merged
merged 20 commits into from
Mar 25, 2025
Merged

SNOW-1918055: Update agg error for unsupported aggregation functions #3133

merged 20 commits into from
Mar 25, 2025

Conversation

sfc-gh-lmukhopadhyay
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay commented Mar 7, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1918055

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Updating groupby.agg and agg error for unsupported aggregation functions to match pandas. It will now return
    'SeriesGroupBy' object has no attribute 'COUNT'

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay added NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs and removed snowpark-pandas labels Mar 7, 2025
@sfc-gh-lmukhopadhyay
fix agg error check
36ccf27 
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay marked this pull request as ready for review March 7, 2025 23:55
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay requested a review from a team as a code owner March 7, 2025 23:56
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay changed the title SNOW-1918055: Update groupby.agg error for unsupported aggregation functions SNOW-1918055: Update agg error for unsupported aggregation functions Mar 7, 2025
sfc-gh-jjiao
sfc-gh-jjiao requested changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-jjiao sfc-gh-jjiao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add a unit test for this function _are_all_agg_funcs_supported_by_snowflake ? we could use some functions that for sure is not going to be supported. I suspect the current code change has a bug. Thanks

@sfc-gh-lmukhopadhyay
update unit tests
d97987a 
Signed-off-by: Labanya Mukhopadhyay <[email protected]>
@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 20, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

sfc-gh-joshi
sfc-gh-joshi reviewed Mar 24, 2025
View reviewed changes
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 98ab013 into main Mar 25, 2025
38 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-1918055-groupby-agg-fix-error branch March 25, 2025 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-jjiao sfc-gh-jjiao sfc-gh-jjiao approved these changes

@sfc-gh-mvashishtha sfc-gh-mvashishtha Awaiting requested review from sfc-gh-mvashishtha sfc-gh-mvashishtha is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-lmukhopadhyay @sfc-gh-snowflakedb-snyk-sa @sfc-gh-joshi @sfc-gh-jjiao